Fix #375 (I think) #434
Merged
Fix #375 (I think) #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses capnproto#375; the now-deleted comment about the time gap being OK has been incorrect at least since we started handling `receiverAnswer`s specially; the test that was failing was one where a reference to an answer's promise filed (and transitively pcall) is handed to a method implementation. This patch avoids having a gap where pcall & promise are nil by: - Changing setPipelineCaller so it can be called before we release the lock - Introducing a stand-in type for the pipeline caller that we can set pcall to while the RecvCall is ongoing. Before fixing the bug it took many thousands or tens of thousands of test runs to trigger it, so while I have not been able to reproduce the issue after tens of thousands of runs, that alone is inconclusive -- but I *think* this fixes the bug. It definitely fixes something.
lthibault
approved these changes
Jan 19, 2023
|
Issue #426, re-running |
|
Same thing. Going to just merge and then work on #426 next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #375; the now-deleted comment about the time gap being OK has been incorrect at least since we started handling
receiverAnswers specially; the test that was failing was one where a reference to an answer's promise filed (and transitively pcall) is handed to a method implementation.This patch avoids having a gap where pcall & promise are nil by:
Before fixing the bug it took many thousands or tens of thousands of test runs to trigger it, so while I have not been able to reproduce the issue after tens of thousands of runs, that alone is inconclusive -- but I think this fixes the bug. It definitely fixes something.