Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding the Terraform module #274

Closed
wants to merge 3 commits into from

Conversation

gatici
Copy link

@gatici gatici commented Jan 31, 2024

Feature

This PR adds the Terraform module for the charm. Hence, the charm could be deployed using Terraform.

Copy link
Contributor

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gatici!
I just skimmed briefly for now.
My impression was that cos in its entirety would be one terraform module.
Is there a particular use case this PR is addressing?

terraform/CONTRIBUTING.md Outdated Show resolved Hide resolved
@gatici
Copy link
Author

gatici commented Feb 6, 2024

Thanks @gatici! I just skimmed briefly for now. My impression was that cos in its entirety would be one Terraform module. Is there a particular use case this PR is addressing?

Hi Leon,
Yes, We need the cos bundle as a Terraform module, that would be perfect if we have it as soon as possible. Besides, Grafana-agent-k8s is part of sdcore bundle. Please see: https://github.com/canonical/sdcore-bundles/blob/552ac796aea231f7e81d2446019e527a7fcd0f12/render_bundle/bundles.py#L42 So we need to deploy Grana Agent charm by Terraform. A Terraform module may include another TF module and could be a part of a higher level TF module. So, creating Grafana Agent TF module could be a starting point.

@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 345e1cd to 533174c Compare February 6, 2024 09:39
Copy link

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments/proposals from my side.

  • I think it would be good to add copyright info to each file.

.github/workflows/terraform.yaml Outdated Show resolved Hide resolved
terraform/main.tf Outdated Show resolved Hide resolved
terraform/main.tf Outdated Show resolved Hide resolved
terraform/main.tf Outdated Show resolved Hide resolved
terraform/main.tf Outdated Show resolved Hide resolved
terraform/terraform.tfvars Outdated Show resolved Hide resolved
terraform/variables.tf Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch 4 times, most recently from 7306d6d to 12dfdcb Compare February 9, 2024 09:45
@gatici gatici requested a review from Gmerold February 9, 2024 10:19
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch 2 times, most recently from dec657c to 9d80ada Compare February 9, 2024 10:57
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 9d80ada to 487c323 Compare February 9, 2024 12:56
.github/workflows/terraform.yaml Outdated Show resolved Hide resolved
terraform/README.md Outdated Show resolved Hide resolved
terraform/README.md Outdated Show resolved Hide resolved
terraform/README.md Outdated Show resolved Hide resolved
terraform/README.md Outdated Show resolved Hide resolved
terraform/README.md Outdated Show resolved Hide resolved
terraform/variables.tf Outdated Show resolved Hide resolved
terraform/variables.tf Outdated Show resolved Hide resolved
terraform/outputs.tf Show resolved Hide resolved
terraform/README.md Outdated Show resolved Hide resolved
@gatici gatici requested a review from Gmerold February 12, 2024 12:43
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 1954f0a to 909bd26 Compare February 12, 2024 13:29
@gatici
Copy link
Author

gatici commented Feb 13, 2024

We will store the grafana-agent-ke8 TF module under this repository temporarily https://github.com/canonical/terraform-juju-sdcore-k8s/pull/4/files. When you had a decision, we can move to it's permanent place.

@gatici gatici closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants