-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding the Terraform module #274
Conversation
a572edb
to
345e1cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gatici!
I just skimmed briefly for now.
My impression was that cos in its entirety would be one terraform module.
Is there a particular use case this PR is addressing?
Hi Leon, |
345e1cd
to
533174c
Compare
Signed-off-by: gatici <[email protected]>
533174c
to
6b335f0
Compare
06e4476
to
a6982ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments/proposals from my side.
- I think it would be good to add copyright info to each file.
7306d6d
to
12dfdcb
Compare
dec657c
to
9d80ada
Compare
Signed-off-by: gatici <[email protected]>
9d80ada
to
487c323
Compare
1954f0a
to
909bd26
Compare
Signed-off-by: gatici <[email protected]>
909bd26
to
7c5e353
Compare
We will store the grafana-agent-ke8 TF module under this repository temporarily https://github.com/canonical/terraform-juju-sdcore-k8s/pull/4/files. When you had a decision, we can move to it's permanent place. |
Feature
This PR adds the Terraform module for the charm. Hence, the charm could be deployed using Terraform.