Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding the Terraform module to deploy SD-Core Bundles #4

Merged
merged 4 commits into from
Feb 15, 2024
Merged

feat: Adding the Terraform module to deploy SD-Core Bundles #4

merged 4 commits into from
Feb 15, 2024

Conversation

gatici
Copy link
Contributor

@gatici gatici commented Jan 31, 2024 •
edited
Loading

Adding the Terraform module to deploy

  • SD-Core Control Plane
  • SD-Core User Plane
  • SD-Core

Note:
This repository is aimed to keep sdcore-control-plane, sdcore-control-plane and sdcore TF modules.
This PR is scoped to add only the sdcore-control-plane TF module.

@gatici gatici requested a review from a team January 31, 2024 15:47
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 735d3c2 to 29326a0 Compare January 31, 2024 15:51
@gatici gatici changed the title feat: Add the Terraform module feat: Adding the Terraform module Jan 31, 2024
@gatici gatici changed the title feat: Adding the Terraform module feat: Adding the Terraform module to deploy SD-Core Control Plane Jan 31, 2024
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 29326a0 to 6ab132a Compare February 2, 2024 13:48
gruyaume
gruyaume reviewed Feb 2, 2024
View reviewed changes
LICENSE Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch 5 times, most recently from 206ee92 to a7b1fb4 Compare February 5, 2024 12:30
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from a7b1fb4 to 3a8d9bb Compare February 7, 2024 09:56
Gmerold
Gmerold reviewed Feb 9, 2024
View reviewed changes
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to store all high level modules in this repo? I mean SD-Core all-in-one, CP and UP?

.github/workflows/issues.yaml Show resolved Hide resolved
.github/workflows/terraform.yaml Outdated Show resolved Hide resolved
Gmerold
Gmerold reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the base modules are merged now (at least SD-Core ones), so we can probably update this PR.

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/README.md Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/README.md Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/README.md Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/README.md Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/README.md Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/README.md Show resolved Hide resolved
modules/sdcore-control-plane-k8s/variables.tf Show resolved Hide resolved
modules/sdcore-control-plane-k8s/main.tf Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 3a8d9bb to 08e02ae Compare February 13, 2024 10:56
Gmerold
Gmerold requested changes Feb 13, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/main.tf Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/main.tf Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/main.tf Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/main.tf Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/main.tf Outdated Show resolved Hide resolved
@gatici gatici changed the title feat: Adding the Terraform module to deploy SD-Core Control Plane feat: Adding the Terraform module to deploy SD-Core Bundles Feb 13, 2024
markbeierl
markbeierl reviewed Feb 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@gatici gatici requested a review from Gmerold February 13, 2024 22:38
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from e913c3c to 626e19f Compare February 13, 2024 22:44
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 626e19f to b925f24 Compare February 13, 2024 22:47
Gmerold
Gmerold reviewed Feb 14, 2024
View reviewed changes
modules/sdcore-control-plane-k8s/variables.tf Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/variables.tf Outdated Show resolved Hide resolved
modules/sdcore-control-plane-k8s/variables.tf Outdated Show resolved Hide resolved
modules/sdcore-user-plane-k8s/README.md Outdated Show resolved Hide resolved
modules/sdcore-user-plane-k8s/README.md Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
Gmerold
Gmerold reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@Gmerold Gmerold left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general comment - I think each module should have output.tf to expose the names of the applications that can have external integrations and the endpoints for those integrations.
For the CP module that would be AMF (fivef-n2), NMS (fiveg_gnb_identity) and grafana_agent (send-remote-write and logging-consumer).
For the UP module that should be UPF (fiveg-n3 and fiveg-n4) and grafana_agent (send-remote-write and logging-consumer).
For all-in-one combination of both.

@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch 2 times, most recently from 7325385 to 7e6083c Compare February 14, 2024 14:24
@gatici
Copy link
Contributor Author

gatici commented Feb 14, 2024

One general comment - I think each module should have output.tf to expose the names of the applications that can have external integrations and the endpoints for those integrations. For the CP module that would be AMF (fivef-n2), NMS (fiveg_gnb_identity) and grafana_agent (send-remote-write and logging-consumer). For the UP module that should be UPF (fiveg-n3 and fiveg-n4) and grafana_agent (send-remote-write and logging-consumer). For all-in-one combination of both.

The output.tf files are added for all the sdcore modules.

@gatici gatici requested a review from Gmerold February 14, 2024 14:26
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 7e6083c to 9354639 Compare February 15, 2024 07:40
Gmerold
Gmerold requested changes Feb 15, 2024
View reviewed changes
modules/sdcore-control-plane-k8s/outputs.tf Show resolved Hide resolved
modules/sdcore-k8s/README.md Outdated Show resolved Hide resolved
modules/sdcore-user-plane-k8s/outputs.tf Show resolved Hide resolved
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 9354639 to 24401de Compare February 15, 2024 08:28
@gatici gatici requested a review from Gmerold February 15, 2024 08:30
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 24401de to 2470ff3 Compare February 15, 2024 08:35
@gatici gatici force-pushed the TELCO-952-Add-terraform-module branch from 2470ff3 to a35f359 Compare February 15, 2024 08:40
Gmerold
Gmerold approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@Gmerold Gmerold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. Well done @gatici!

@gatici
Copy link
Contributor Author

gatici commented Feb 15, 2024

Terraform check action fails because of default TF modules path. This will be fixed after merging: canonical/sdcore-github-workflows#31

@gatici
Copy link
Contributor Author

gatici commented Feb 15, 2024

That looks good to me. Well done @gatici!

Thanks for your great help and guidance @Gmerold !!

@gatici gatici merged commit 57f3af1 into main Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gmerold Gmerold Gmerold approved these changes

@gruyaume gruyaume Awaiting requested review from gruyaume

@markbeierl markbeierl Awaiting requested review from markbeierl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gatici @gruyaume @markbeierl @Gmerold