Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqs): remove pattern validation in runtime, add override description to template #3366

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

mathias-vandaele
Copy link
Contributor

@mathias-vandaele mathias-vandaele commented Sep 27, 2024

Description

These changes allow old SQS element templates to be used with the latest Connectors runtime

Related issues

related https://github.com/camunda/team-connectors/issues/922

Checklist

  • PR has a milestone or the no milestone label.

Copy link
Collaborator

@ev-codes ev-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this quick PR!

@ev-codes ev-codes changed the title fix(sqs): add last minute fix (discussed with the team) fix(sqs): remove pattern validation in runtime, add override description to template Sep 27, 2024
@ev-codes ev-codes added version:8.6.0 Label that represents issues released on version 8.6.0 and removed version:8.6.0 Label that represents issues released on version 8.6.0 labels Sep 27, 2024
@ev-codes ev-codes added this to the 8.6.0 milestone Sep 27, 2024
Copy link
Collaborator

@ev-codes ev-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed the issues now myself due to time constraints.

@ev-codes ev-codes added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@ev-codes ev-codes added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 02fe7cb Sep 27, 2024
26 of 31 checks passed
@ev-codes ev-codes deleted the sqs-inbound-connector-last-fixes branch September 27, 2024 11:00
github-actions bot pushed a commit that referenced this pull request Sep 27, 2024
…ion to template (#3366)

* fix(sqs): add last minute fix (discussed with the team)

* docs(readme): fix Spotless formatting issues

---------

Co-authored-by: Ev Bilske <[email protected]>
(cherry picked from commit 02fe7cb)
Copy link
Contributor

ev-codes pushed a commit that referenced this pull request Sep 27, 2024
…ion to template (#3366)

* fix(sqs): add last minute fix (discussed with the team)

* docs(readme): fix Spotless formatting issues

---------

Co-authored-by: Ev Bilske <[email protected]>
(cherry picked from commit 02fe7cb)
ev-codes pushed a commit that referenced this pull request Sep 27, 2024
…ion to template (#3366) (#3369)

* fix(sqs): add last minute fix (discussed with the team)

* docs(readme): fix Spotless formatting issues

---------

Co-authored-by: Ev Bilske <[email protected]>
(cherry picked from commit 02fe7cb)

Co-authored-by: Mathias Vandaele <[email protected]>
ev-codes pushed a commit that referenced this pull request Sep 27, 2024
…ion to template (#3366) (#3369)

* fix(sqs): add last minute fix (discussed with the team)

* docs(readme): fix Spotless formatting issues

---------

Co-authored-by: Ev Bilske <[email protected]>
(cherry picked from commit 02fe7cb)

Co-authored-by: Mathias Vandaele <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants