fix(sqs): remove pattern validation in runtime, add override descript…

…ion to template (#3366) * fix(sqs): add last minute fix (discussed with the team) * docs(readme): fix Spotless formatting issues --------- Co-authored-by: Ev Bilske <[email protected]> (cherry picked from commit 02fe7cb)
camunda · Sep 27, 2024 · 1c0bae3 · 1c0bae3
1 parent 896f874
commit 1c0bae3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/connectors/aws/aws-sqs/element-templates/aws-sqs-boundary-connector.json b/connectors/aws/aws-sqs/element-templates/aws-sqs-boundary-connector.json
@@ -149,13 +149,13 @@
   }, {
     "id" : "queue.queue.pollingWaitTime",
     "label" : "Polling wait time",
-    "description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details",
+    "description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details. A value of 0 will automatically be overridden to 1",
     "optional" : false,
     "value" : "20",
     "constraints" : {
       "notEmpty" : true,
       "pattern" : {
-        "value" : "^([1-9]?|1[0-9]|20|secrets\\..+)$"
+        "value" : "^([0-9]?|1[0-9]|20|secrets\\..+)$"
       }
     },
     "group" : "messagePollingProperties",

diff --git a/connectors/aws/aws-sqs/element-templates/aws-sqs-inbound-intermediate-connector.json b/connectors/aws/aws-sqs/element-templates/aws-sqs-inbound-intermediate-connector.json
@@ -149,13 +149,13 @@
   }, {
     "id" : "queue.queue.pollingWaitTime",
     "label" : "Polling wait time",
-    "description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details",
+    "description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details. A value of 0 will automatically be overridden to 1",
     "optional" : false,
     "value" : "20",
     "constraints" : {
       "notEmpty" : true,
       "pattern" : {
-        "value" : "^([1-9]?|1[0-9]|20|secrets\\..+)$"
+        "value" : "^([0-9]?|1[0-9]|20|secrets\\..+)$"
       }
     },
     "group" : "messagePollingProperties",

diff --git a/connectors/aws/aws-sqs/element-templates/aws-sqs-start-message.json b/connectors/aws/aws-sqs/element-templates/aws-sqs-start-message.json
@@ -149,13 +149,13 @@
   }, {
     "id" : "queue.queue.pollingWaitTime",
     "label" : "Polling wait time",
-    "description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details",
+    "description" : "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details. A value of 0 will automatically be overridden to 1",
     "optional" : false,
     "value" : "20",
     "constraints" : {
       "notEmpty" : true,
       "pattern" : {
-        "value" : "^([1-9]?|1[0-9]|20|secrets\\..+)$"
+        "value" : "^([0-9]?|1[0-9]|20|secrets\\..+)$"
       }
     },
     "group" : "messagePollingProperties",

diff --git a/...s/aws-sqs/src/main/java/io/camunda/connector/inbound/model/SqsInboundQueueProperties.java b/...s/aws-sqs/src/main/java/io/camunda/connector/inbound/model/SqsInboundQueueProperties.java
@@ -44,8 +44,8 @@ public record SqsInboundQueueProperties(
             group = "messagePollingProperties",
             defaultValue = "20",
             description =
-                "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details",
+                "The duration (in seconds) for which the call waits for a message to arrive in the queue before returning. See <a href=\"https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/amazon-sqs/?amazonsqs=inbound\" target=\"_blank\">documentation</a> for details. A value of 0 will automatically be overridden to 1",
             feel = FeelMode.disabled)
-        @Pattern(regexp = "^([1-9]?|1[0-9]|20|secrets\\..+)$")
+        @Pattern(regexp = "^([0-9]?|1[0-9]|20|secrets\\..+)$")
         @NotBlank
         String pollingWaitTime) {}