Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medicare: Add Medicare copy for Spanish #2406

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

machikoyasuda
Copy link
Member

closes #2369

I just noticed the strings had been updated in Ditto, so I decided to finish this last Medicare-related issue up.

Nitty gritty copy details

I tried to see if any of the Filters work, but I found this was the best way:

Type medicare into the search box, to filter the strings:
image

Then you get strings with medicare in them:
image

Then, click the Spanish tab:
image

Then, look to the right-hand sidebar to confirm: The English with the Spanish, and the Figma thumbnail very helpfully shows where the string goes exactly in the interface.
image

Compare the Text/Variant text fields in Ditto with the django.po file msgid and msgstr
image

Just to double check that the Ditto and iBabbleOn JSON were correct, I double-checked that the Ditto/Django.po text is the same as the JSON, by searching by the component.id from Ditto in the JSON:

image

@machikoyasuda machikoyasuda requested a review from a team as a code owner September 25, 2024 20:38
@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework labels Sep 25, 2024
@machikoyasuda machikoyasuda self-assigned this Sep 25, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation looks good! And thanks for the tips on how to use Ditto for this, super useful! 😊

@machikoyasuda machikoyasuda merged commit 861519e into main Sep 26, 2024
13 checks passed
@machikoyasuda machikoyasuda deleted the feat/2369-medicare-spanish branch September 26, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Medicare cardholder: Spanish translations
2 participants