Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: transit agency user group #2307

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Feat: transit agency user group #2307

merged 4 commits into from
Aug 19, 2024

Conversation

angela-tran
Copy link
Member

Part of #2243

This PR associates a user to a TransitAgency through their group membership.

@angela-tran angela-tran self-assigned this Aug 16, 2024
@angela-tran angela-tran requested a review from a team as a code owner August 16, 2024 17:39
@github-actions github-actions bot added back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.) deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates labels Aug 16, 2024
@angela-tran angela-tran changed the title Feat/transit agency group Feat: transit agency user group Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  benefits/core
  models.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start, and I see that we have the reverse access so that's nice 👍

Small request to rename the field for clarity. Also I think you'll want to rebase on #2299 -- that PR has a migration as well, and it is nearly done.

benefits/core/models.py Outdated Show resolved Hide resolved
benefits/core/migrations/0022_transitagency_group.py Outdated Show resolved Hide resolved
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@angela-tran angela-tran merged commit 1f7c02e into main Aug 19, 2024
15 checks passed
@angela-tran angela-tran deleted the feat/transit-agency-group branch August 19, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. deployment-dev [auto] Changes that will trigger a deploy if merged to dev tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants