chore: rename field on TransitAgency

to clarify it's the group of staff users, not the enrollment group

benefits/core/migrations/0022_transitagency_group.py

@@ -1,4 +1,4 @@
-# Generated by Django 5.0.7 on 2024-08-16 16:08
+# Generated by Django 5.0.7 on 2024-08-19 14:53
 
 import django.db.models.deletion
 from django.db import migrations, models
@@ -14,7 +14,7 @@ class Migration(migrations.Migration):
     operations = [
         migrations.AddField(
             model_name="transitagency",
-            name="group",
+            name="staff_group",
             field=models.OneToOneField(
                 blank=True,
                 default=None,

benefits/core/models.py

@@ -353,7 +353,7 @@ class TransitAgency(models.Model):
         help_text="The name of the secret containing this agency's client_secret value used to access the TransitProcessor's API.",  # noqa: E501
         default="",
     )
-    group = models.OneToOneField(
+    staff_group = models.OneToOneField(
         Group,
         on_delete=models.PROTECT,
         null=True,

tests/pytest/core/test_models.py

@@ -473,7 +473,7 @@ def test_TransitAgency_for_user_in_group(model_TransitAgency):
 
     agency_for_user = TransitAgency.by_id(model_TransitAgency.id)
     agency_for_user.pk = None
-    agency_for_user.group = group
+    agency_for_user.staff_group = group
     agency_for_user.save()
 
     user = User.objects.create_user(username="test_user", email="[email protected]", password="test", is_staff=True)
@@ -488,7 +488,7 @@ def test_TransitAgency_for_user_not_in_group(model_TransitAgency):
 
     agency_for_user = TransitAgency.by_id(model_TransitAgency.id)
     agency_for_user.pk = None
-    agency_for_user.group = group
+    agency_for_user.staff_group = group
     agency_for_user.save()
 
     user = User.objects.create_user(username="test_user", email="[email protected]", password="test", is_staff=True)