Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: check for up-to-date migrations #2122

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented May 24, 2024

Closes #2092

I tested this locally with act:
image

I think this will need to be reviewed, approved, and merged into dev before we can see it in action on a PR.

run when files under /benefits are changed in a pull request or push
fail if expected message is not present ("No changes detected")
@angela-tran angela-tran self-assigned this May 24, 2024
@angela-tran angela-tran requested a review from a team as a code owner May 24, 2024 19:10
@github-actions github-actions bot added the actions Related to GitHub Actions workflows label May 24, 2024
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@lalver1
Copy link
Member

lalver1 commented May 30, 2024

Nice! I hadn't had a chance to try act but I ran this workflow locally with it today and it looks good!

@angela-tran angela-tran merged commit e7d42d3 into dev May 30, 2024
10 checks passed
@angela-tran angela-tran deleted the ci/check-makemigrations branch May 30, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Related to GitHub Actions workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a PR check to ensure migrations are up to date
3 participants