Feat: check makemessages #2155
Merged
Feat: check makemessages #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the same workflow to minimize time spent on required checks
Coverage report
This PR does not seem to contain any modification to coverable code. |
thekaveman
approved these changes
Jun 10, 2024
Thanks! I updated the branch protection for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2122, this PR adds a workflow to check that the Django message files are up-to-date.
Rather than making a new workflow, I added a step to the existing
check-makemigrationsworkflow so that the two steps can use the same runner that has already checked out the repo, installed system packages, installed Python packages, etc. and to minimize the amount time it takes to check migrations and messages. (See #2092 (comment) for more context on required checks.)