-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update Spanish tense for Login.gov modal #1712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least one more snuck in at the bottom: https://github.com/cal-itp/benefits/pull/1712/files#diff-748b0299f076e6e9a7c2a8bd1ecae94e02768b9c07bd8a84ddfa4ebdb62752fdR576
7dcdab1
to
e85122f
Compare
@thekaveman Thanks for that catch! I searched thru the Spanish file to make sure there aren't any more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇪🇸 ✔️
Hey folks- I'm giving a talk about modern software delivery to some public policy students today and this was a great example for me to show. Thanks again for working in the open! 🌤️ 🙌 |
Nice to see you @afeld! |
closes #1709
The rest of the Spanish copy on the app uses the formal usted tense (for pronouns, verbs). This PR updates the Login.gov modal from informal tu tense to formal usted tense.
Note: This would be important to note in the #1653 as instructions for Spanish translation teams.