Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove Page viewmodel #1563

Merged
merged 9 commits into from
Jul 31, 2023
Merged

Refactor: remove Page viewmodel #1563

merged 9 commits into from
Jul 31, 2023

Conversation

thekaveman
Copy link
Member

@thekaveman thekaveman commented Jul 23, 2023 •
edited
Loading

Closes #1442 as the final viewmodels.Page is removed and the module is deleted.

@github-actions github-actions bot added front-end HTML/CSS/JavaScript and Django templates back-end Django views, sessions, middleware, models, migrations etc. migrations [auto] Review for potential model changes/needed data migrations updates i18n Copy: Language files or Django i18n framework tests Related to automated testing (unit, UI, integration, etc.) labels Jul 23, 2023
@thekaveman thekaveman mentioned this pull request Jul 23, 2023
Closed
20 tasks
@thekaveman thekaveman self-assigned this Jul 23, 2023
Base automatically changed from refactor/buttons to dev July 25, 2023 22:27
@thekaveman thekaveman marked this pull request as ready for review July 25, 2023 22:27
@thekaveman thekaveman requested a review from a team as a code owner July 25, 2023 22:27
@thekaveman thekaveman linked an issue Jul 25, 2023 that may be closed by this pull request
Refactor usage of view models #1442
Closed
20 tasks
@thekaveman thekaveman marked this pull request as draft July 25, 2023 23:02
@thekaveman
Copy link
Member Author

I'm going to rebase this on #1566 since they both touch the homepage, but this one more significantly, to deal with conflicts now vs. later.

@thekaveman
Copy link
Member Author

I'm going to rebase this on #1566 since they both touch the homepage, but this one more significantly, to deal with conflicts now vs. later.

Since this PR is already on the latest dev, and #1566 is still behind the latest dev, I'm just going to hold this one until #1566 is merged and rebase then.

@thekaveman thekaveman force-pushed the refactor/viewmodel-page branch 3 times, most recently from da996be to 6c09a80 Compare July 28, 2023 15:08
@thekaveman thekaveman marked this pull request as ready for review July 28, 2023 15:10
machikoyasuda
machikoyasuda previously approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went thru full flow for Courtesy Card, went thru Help page, went thru both Agency Indexes, tested headlines/titles

@thekaveman
Copy link
Member Author

Rebased on latest dev to resolve conflicts.

machikoyasuda
machikoyasuda approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@machikoyasuda machikoyasuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

fixes the current issue on dev where some of the page titles have an extra space after the | ...

angela-tran
angela-tran approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@angela-tran angela-tran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thekaveman thekaveman merged commit 868cfbe into dev Jul 31, 2023
12 checks passed
@thekaveman thekaveman deleted the refactor/viewmodel-page branch July 31, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@angela-tran angela-tran angela-tran approved these changes

Assignees

@thekaveman thekaveman

Labels
back-end Django views, sessions, middleware, models, migrations etc. front-end HTML/CSS/JavaScript and Django templates i18n Copy: Language files or Django i18n framework migrations [auto] Review for potential model changes/needed data migrations updates tests Related to automated testing (unit, UI, integration, etc.)
Projects
None yet
Milestone
UI composition improvements [eng]
Development

Successfully merging this pull request may close these issues.

Refactor usage of view models
3 participants
@thekaveman @machikoyasuda @angela-tran