Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Help page - Login.gov sections #1559

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Chore: Help page - Login.gov sections #1559

merged 3 commits into from
Jul 25, 2023

Conversation

angela-tran
Copy link
Member

Part of #1544

This PR updates the sections explaining Login.gov and identity verification via Login.gov. The copy should match the help modals with one exception being that the sentence about visiting the help center (shows up under the first section rather than the second).

As shown in Figma:
image

@angela-tran angela-tran added this to the Veterans milestone Jul 21, 2023
@angela-tran angela-tran self-assigned this Jul 21, 2023
@github-actions github-actions bot added i18n Copy: Language files or Django i18n framework front-end HTML/CSS/JavaScript and Django templates deployment-dev [auto] Changes that will trigger a deploy if merged to dev and removed front-end HTML/CSS/JavaScript and Django templates labels Jul 21, 2023
@angela-tran angela-tran marked this pull request as ready for review July 25, 2023 19:14
@angela-tran angela-tran requested a review from a team as a code owner July 25, 2023 19:14
thekaveman
thekaveman approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, this looks fine for now but this help page is kind of a bummer! Definitely going to break our "separate the strings into the apps that use them" idea unless we go full duplicate content 👎 Maybe some day we can get rid of it.

@angela-tran
Copy link
Member Author

Ugh, this looks fine for now but this help page is kind of a bummer! Definitely going to break our "separate the strings into the apps that use them" idea unless we go full duplicate content 👎 Maybe some day we can get rid of it.

Yeah, I agree!

@angela-tran angela-tran merged commit ed4ccbc into dev Jul 25, 2023
10 checks passed
@angela-tran angela-tran deleted the chore/help-copy-login-gov branch July 25, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekaveman thekaveman thekaveman approved these changes

Assignees

@angela-tran angela-tran

Labels
deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework
Projects
None yet
Milestone
Veteran rider enrollment pathway
Development

Successfully merging this pull request may close these issues.
2 participants
@angela-tran @thekaveman