Include tags to plugins #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
68
to
91
| document.addEventListener('DOMContentLoaded', function () { | ||
| var checkboxes = document.querySelectorAll('.category-checkbox'); | ||
| var selectedCategoriesInput = document.getElementById('SelectedCategories'); | ||
| var dropdownButton = document.getElementById('dropdownMenuButton'); | ||
| function updateButtonLabel() { | ||
| var selectedCategories = []; | ||
| checkboxes.forEach(function (cb) { | ||
| if (cb.checked) { | ||
| selectedCategories.push(cb.value); | ||
| } | ||
| }); | ||
| selectedCategoriesInput.value = selectedCategories.join(','); | ||
|
|
||
| if (selectedCategories.length > 0) { | ||
| dropdownButton.textContent = selectedCategories.length + ' tag' + (selectedCategories.length > 1 ? 's' : '') + ' selected'; | ||
| } else { | ||
| dropdownButton.textContent = 'Select tags'; | ||
| } | ||
| } | ||
| checkboxes.forEach(function (checkbox) { | ||
| checkbox.addEventListener('change', updateButtonLabel); | ||
| }); | ||
| updateButtonLabel(); | ||
| }); |
There was a problem hiding this comment.
You can put this in a separate JS file to avoid duplication. You could also encapsulate the view part above in a view component and eliminate that duplication too this way.
There was a problem hiding this comment.
Decided to remove that, and use just input for tags using tom-select.
You can go ahead and review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow plugin owners to specify tags, such that on BTCPay, filters are easy to carry out.
@NicolasDorier