-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Allow dependency rustworkx 0.14.x #6045
base: main
Are you sure you want to change the base?
Conversation
Hi folks, just to give a little bit more of context to Chongyi's PR. From what I understood, many users use However, one item we missed were The diff of the PR is small but the consequence is that many Mac users will now be able to run Alpine-based Docker containers |
Thanks for the comment @IvanIsCoding super-linter which includes |
You also need to adjust the As mentioned in other issues and also in the docs, |
It's updated. |
@gruebel Can you help to review this again? Thanks |
@gruebel Is there anything blocking that I need to help with? Can you allow the workflows to run so that I would know if there's any issues? Thanks This PR will reduce build time on |
bump manully bc-detect-secrets Co-authored-by: Max Amelchenko <[email protected]>
bump manully bc-detect-secrets Co-authored-by: Max Amelchenko <[email protected]>
add fix for when tf_def is a string Co-authored-by: Max Amelchenko <[email protected]>
add fix for when tf_def is a string Co-authored-by: Max Amelchenko <[email protected]>
@harryzcy |
@pazbechor Thank you! I just fixed the conflicts |
@pazbechor @gruebel can you review the changes? |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Allow using
rustworkx
0.13.x and 0.14.x.rustworkx
0.13.0 doesn't provide a arm64 linux support withmusl
(musllinux2014_aarch64). Thus, installing requires a Rust compiler.rustworkx
0.14.x solves this (see Qiskit/rustworkx#1115).Checklist: