Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JS api url sanitation. #25644

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fixed JS api url sanitation. #25644

merged 2 commits into from
Sep 23, 2024

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Sep 19, 2024

Resolves brave/brave-browser#41064

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@boocmp boocmp requested a review from fmarier September 19, 2024 06:06
@boocmp boocmp self-assigned this Sep 19, 2024
@boocmp boocmp requested a review from a team as a code owner September 19, 2024 06:06
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src lgtm

@boocmp boocmp merged commit 203bf41 into master Sep 23, 2024
19 checks passed
@boocmp boocmp deleted the issues/41064 branch September 23, 2024 02:52
@github-actions github-actions bot added this to the 1.72.x - Nightly milestone Sep 23, 2024
@boocmp boocmp restored the issues/41064 branch September 23, 2024 03:01
boocmp added a commit that referenced this pull request Sep 23, 2024
* Fixed JS api url sanitation.
@boocmp boocmp deleted the issues/41064 branch September 23, 2024 03:09
boocmp added a commit that referenced this pull request Sep 23, 2024
* Fixed JS api url sanitation.
boocmp added a commit that referenced this pull request Sep 23, 2024
* Fixed JS api url sanitation.
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.72.34 Chromium: 129.0.6668.59 (Official Build) nightly (64-bit)
-- | --
Revision | 74bf470a0291ea3719f1a75af066ee10b7057dbd
OS | Windows 11 Version 23H2 (Build 22631.4169)

Reproduced the original issue using 1.72.31 Chromium: 129.0.6668.59 with the STR/Cases outlined via brave/brave-browser#41064 (comment) & https://fmarier.github.io/brave-testing/clipboard.html.

Once the above was reproduced, ensured that the above cases were correctly working and the correct text/strings/links were being copied as per the following:

  • visited vault.bitwarden.com and created a new entry with ASDASD:asd^ASD,ASD as the password
  • once the new entry was created, ensured that copying via the icon copied/pasted ASDASD:asd^ASD,ASD
  • visited https://fmarier.github.io/brave-testing/clipboard.html and ensured that A:^C,D was copied/pasted

kjozwiak pushed a commit that referenced this pull request Sep 24, 2024
Fixed JS api url sanitation. (#25644)

* Fixed JS api url sanitation.
kjozwiak pushed a commit that referenced this pull request Sep 24, 2024
Fixed JS api url sanitation. (#25644)

* Fixed JS api url sanitation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy/Paste Issue
4 participants