Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed JS api url sanitation. (uplift to 1.71.x) #25689

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fixed JS api url sanitation. (uplift to 1.71.x) #25689

merged 1 commit into from
Sep 24, 2024
+117 −52

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Sep 23, 2024 •
edited by kjozwiak
Loading

Uplift of #25644
Resolves brave/brave-browser#41064

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@boocmp
Fixed JS api url sanitation. (#25644)
826d977 
* Fixed JS api url sanitation.
@boocmp boocmp self-assigned this Sep 23, 2024
@boocmp boocmp requested a review from a team as a code owner September 23, 2024 03:10
@kjozwiak kjozwiak added this to the 1.71.x - Beta milestone Sep 24, 2024
kjozwiak
kjozwiak approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.71.x approved 👍 QA has verified the PR on Nightly using 1.72.x as per #25644 (comment).

@kjozwiak kjozwiak merged commit b417517 into 1.71.x Sep 24, 2024
16 checks passed
@kjozwiak kjozwiak deleted the pr25644_issues_1.71.x/41064 branch September 24, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@boocmp boocmp

Labels
None yet
Projects
None yet
Milestone
1.71.x - Beta
Development

Successfully merging this pull request may close these issues.
2 participants
@boocmp @kjozwiak