Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fingerprint and proxy #2555

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fingerprint and proxy #2555

wants to merge 2 commits into from

Conversation

ibukanov
Copy link
Collaborator

@ibukanov ibukanov commented Jun 6, 2024

Use tls.Config.VerifyPeerCertificate, not the dialer, to verify the Uphold TLS certificate fingerprint. This ensures that the fingerprint checks are done even if a proxy is used.

Summary

Type of Change

  • Product feature
  • [x ] Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • [ x] Development
  • Staging
  • Production

Before Requesting Review

  • [ x] Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security and/or privacy review if needed
  • [ x] Have you performed a self review of this PR?

Manual Test Plan

@ibukanov ibukanov requested a review from evq June 6, 2024 21:41
@ibukanov ibukanov requested a review from Sneagan June 26, 2024 14:46
@ibukanov
fix: fingerprint and proxy
54bb1f2 
Use tls.Config.VerifyPeerCertificate, not the dialer, to verify the
Uphold TLS certificate fingerprint. This ensures that the fingerprint
checks are done even if a proxy is used.
@ibukanov
chore: Docker volumes with relative paths
aefce38 
Docker supports using relative path for bind-mounted volumes. So use
those rather than PWD. This also makes Makefile more compatible with
Windows.
@ibukanov ibukanov removed the request for review from evq August 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sneagan Sneagan Awaiting requested review from Sneagan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ibukanov