Skip to content

Commit

Permalink
chore: Docker volumes with relative paths
Browse files Browse the repository at this point in the history
Docker supports using relative path for bind-mounted volumes. So use
those rather than PWD. This also makes Makefile more compatible with
Windows.
  • Loading branch information
ibukanov committed Jun 10, 2024
1 parent 3aa1e7a commit 049dcd4
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ docker:
docker tag bat-go:$(GIT_VERSION)$(BUILD_TIME) bat-go:latest

docker-reproducible:
docker run -v $(PWD):/workspace --network=host \
docker run -v .:/workspace --network=host \
gcr.io/kaniko-project/executor:latest \
--reproducible --dockerfile /workspace/Dockerfile \
--no-push --tarPath /workspace/bat-go-repro.tar \
Expand Down Expand Up @@ -190,11 +190,11 @@ format-lint:
make format && make lint

lint: ensure-gomod-volume
docker run --rm -v "$$(pwd):/app" -v batgo_lint_gomod:/go/pkg --workdir /app/main golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v "$$(pwd):/app" -v batgo_lint_gomod:/go/pkg --workdir /app/cmd golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v "$$(pwd):/app" -v batgo_lint_gomod:/go/pkg --workdir /app/libs golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v "$$(pwd):/app" -v batgo_lint_gomod:/go/pkg --workdir /app/services golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v "$$(pwd):/app" -v batgo_lint_gomod:/go/pkg --workdir /app/tools golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v ".:/app" -v batgo_lint_gomod:/go/pkg --workdir /app/main golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v ".:/app" -v batgo_lint_gomod:/go/pkg --workdir /app/cmd golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v ".:/app" -v batgo_lint_gomod:/go/pkg --workdir /app/libs golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v ".:/app" -v batgo_lint_gomod:/go/pkg --workdir /app/services golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...
docker run --rm -v ".:/app" -v batgo_lint_gomod:/go/pkg --workdir /app/tools golangci/golangci-lint:v1.49.0 golangci-lint run -v ./...

download-mod:
cd ./cmd && go mod download && cd ..
Expand Down

0 comments on commit 049dcd4

Please sign in to comment.