Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation history modal to show leveraging and integrity check messages #960

Merged
merged 7 commits into from
Jul 14, 2023
Merged

Translation history modal to show leveraging and integrity check messages #960

merged 7 commits into from
Jul 14, 2023

Commits on Jul 13, 2023

  1. Save integrity checker errors during TextUnitBatchImporterService's b… 

    …atch import

we're currently not saving the error for that import implementation while we do it in other imports, see AbstractImportTranslationsStep/ImportExportedXliffStep
    @aurambaj
    aurambaj committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3ebbbed View commit details
    Browse the repository at this point in the history

  2. Surface more information when the message format integrity checker fails

    @aurambaj
    aurambaj committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    cc9a1f0 View commit details
    Browse the repository at this point in the history

  3. Better logging for integrity checker failures

    @aurambaj
    aurambaj committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    388a75b View commit details
    Browse the repository at this point in the history

  4. Include variant comments in /api/textunits/{tmTextUnitId}/history 

    Add TMTextUnitVariantComment to the TranslationHistorySummary JSON view. This API will now include the variant comments in the payload.

This will be used by in the frontend to surface more information related to leveraging, and integrity checker failures.
    @aurambaj
    aurambaj committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    4edbb2c View commit details
    Browse the repository at this point in the history

  5. pre-indent with prettier 

    so that next commit just show relevant change
    @aurambaj
    aurambaj committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3c2bfe1 View commit details
    Browse the repository at this point in the history

  6. Document the value of md5 for monolingual document, eg. import 

    this relates to running integrity checker during import localized asset but not pursuing the other update at the moment
    @aurambaj
    aurambaj committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d98e8e3 View commit details
    Browse the repository at this point in the history

  7. Translation history modal to show leveraging and integrity check mess… 

    …ages

This helps to bring visibility to the translation status by showing the root cause of a "rejected" string or a "need translation" string due to leveraging or integrity checks.

If there are "comments" on a text unit variant then an accordion will be display. Expanding the accordion will show log style information, typically leveraging and integrity checks messages
    @aurambaj
    aurambaj committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    071ed73 View commit details
    Browse the repository at this point in the history