Translation history modal to show leveraging and integrity check messages #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurambaj
force-pushed
the
ja/importTargetComment
branch
from
88f8004
to
15c19ca
Compare
aurambaj
changed the title
|
new modal: 
old modal: |
…atch import we're currently not saving the error for that import implementation while we do it in other imports, see AbstractImportTranslationsStep/ImportExportedXliffStep
aurambaj
force-pushed
the
ja/importTargetComment
branch
from
15c19ca
to
6d72032
Compare
hylstonnb
reviewed
Jul 13, 2023
| @ResponseStatus(HttpStatus.OK) | ||
| @JsonView(View.TranslationHistorySummary.class) | ||
| public List<TMTextUnitVariant> getTextUnitHistory( | ||
| @PathVariable Long textUnitId, | ||
| @PathVariable Long tmTextUnitId, |
There was a problem hiding this comment.
as you are just changing a path variable name, I don't think there is anything relying on that name, right?
There was a problem hiding this comment.
exact, no other change beside making the code more readable. With the previous name it was not clear at first sight which id exactly it was.
webapp/src/main/java/com/box/l10n/mojito/service/tm/importer/TextUnitBatchImporterService.java
Show resolved
Hide resolved
Add TMTextUnitVariantComment to the TranslationHistorySummary JSON view. This API will now include the variant comments in the payload. This will be used by in the frontend to surface more information related to leveraging, and integrity checker failures.
so that next commit just show relevant change
this relates to running integrity checker during import localized asset but not pursuing the other update at the moment
…ages This helps to bring visibility to the translation status by showing the root cause of a "rejected" string or a "need translation" string due to leveraging or integrity checks. If there are "comments" on a text unit variant then an accordion will be display. Expanding the accordion will show log style information, typically leveraging and integrity checks messages
aurambaj
force-pushed
the
ja/importTargetComment
branch
from
6d72032
to
071ed73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.