-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation history modal to show leveraging and integrity check messages #960
Conversation
88f8004
to
15c19ca
Compare
…atch import we're currently not saving the error for that import implementation while we do it in other imports, see AbstractImportTranslationsStep/ImportExportedXliffStep
15c19ca
to
6d72032
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these chances. Adding a few comments
@ResponseStatus(HttpStatus.OK) | ||
@JsonView(View.TranslationHistorySummary.class) | ||
public List<TMTextUnitVariant> getTextUnitHistory( | ||
@PathVariable Long textUnitId, | ||
@PathVariable Long tmTextUnitId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you are just changing a path variable name, I don't think there is anything relying on that name, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exact, no other change beside making the code more readable. With the previous name it was not clear at first sight which id exactly it was.
webapp/src/main/java/com/box/l10n/mojito/service/tm/importer/TextUnitBatchImporterService.java
Show resolved
Hide resolved
Add TMTextUnitVariantComment to the TranslationHistorySummary JSON view. This API will now include the variant comments in the payload. This will be used by in the frontend to surface more information related to leveraging, and integrity checker failures.
so that next commit just show relevant change
this relates to running integrity checker during import localized asset but not pursuing the other update at the moment
…ages This helps to bring visibility to the translation status by showing the root cause of a "rejected" string or a "need translation" string due to leveraging or integrity checks. If there are "comments" on a text unit variant then an accordion will be display. Expanding the accordion will show log style information, typically leveraging and integrity checks messages
6d72032
to
071ed73
Compare
No description provided.