Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discontinued bucket can't be migrated #625

Merged
merged 3 commits into from
May 28, 2024
Merged

fix: discontinued bucket can't be migrated #625

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b3ce5d
fix: discontinued bucket can't be migrated
BarryTong65 May 21, 2024
df3028c
fix: check veld upgrade
BarryTong65 May 27, 2024
5c90fbc
Merge branch 'develop' into fix-migrate-buckets
BarryTong65 May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x/storage/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2129,6 +2129,10 @@ func (k Keeper) MigrateBucket(ctx sdk.Context, operator sdk.AccAddress, bucketNa
return types.ErrInvalidBucketStatus.Wrapf("The bucket already been migrating")
}

if bucketInfo.BucketStatus == types.BUCKET_STATUS_DISCONTINUED {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we check if it is hardfork , e.g.

if !ctx.IsUpgraded(upgradetypes.xxx) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

return types.ErrInvalidBucketStatus.Wrapf("The discontinued bucket cannot be migrated")
}

srcSP := k.MustGetPrimarySPForBucket(ctx, bucketInfo)

dstSP, found := k.spKeeper.GetStorageProvider(ctx, dstPrimarySPID)
Expand Down
Loading