fix: discontinued bucket can't be migrated #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryTong65
force-pushed
the
fix-migrate-buckets
branch
from
b5bb0c8
to
7b3ce5d
Compare
BarryTong65
changed the title
ruojunm
reviewed
May 24, 2024
x/storage/keeper/keeper.go
Outdated
| @@ -2129,6 +2129,10 @@ func (k Keeper) MigrateBucket(ctx sdk.Context, operator sdk.AccAddress, bucketNa | |||
| return types.ErrInvalidBucketStatus.Wrapf("The bucket already been migrating") | |||
| } | |||
|
|
|||
| if bucketInfo.BucketStatus == types.BUCKET_STATUS_DISCONTINUED { | |||
There was a problem hiding this comment.
should we check if it is hardfork , e.g.
if !ctx.IsUpgraded(upgradetypes.xxx) {
# Conflicts: # go.mod # go.sum
alexgao001
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: discontinued bucket can't be migrated
Rationale
N/A
Example
N/A
Changes
Notable changes:
Potential Impacts