chore: payment refactor to use global store prices for billing #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
force-pushed
the
payment_refactor
branch
3 times, most recently
from
b7810ae
to
ac40f56
Compare
pythonberg1997
approved these changes
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
unclezoro
reviewed
Aug 10, 2023
unclezoro
requested changes
Aug 10, 2023
forcodedancing
force-pushed
the
payment_refactor
branch
2 times, most recently
from
2141b5f
to
61dd9d0
Compare
forcodedancing
commented
Aug 10, 2023
go.mod
Outdated
| @@ -177,7 +177,7 @@ replace ( | |||
| github.com/cometbft/cometbft => github.com/bnb-chain/greenfield-cometbft v0.0.2 | |||
| github.com/cometbft/cometbft-db => github.com/bnb-chain/greenfield-cometbft-db v0.8.1-alpha.1 | |||
| github.com/confio/ics23/go => github.com/cosmos/cosmos-sdk/ics23/go v0.8.0 | |||
| github.com/cosmos/cosmos-sdk => github.com/bnb-chain/greenfield-cosmos-sdk v0.2.4-alpha.1 | |||
| github.com/cosmos/cosmos-sdk => github.com/bnb-chain/greenfield-cosmos-sdk v0.2.3-alpha.3.0.20230810070304-b0d00febdec4 | |||
There was a problem hiding this comment.
check this: bnb-chain/greenfield-cosmos-sdk#267
forcodedancing
force-pushed
the
payment_refactor
branch
from
61dd9d0
to
ec38fe7
Compare
unclezoro
reviewed
Aug 14, 2023
unclezoro
reviewed
Aug 14, 2023
unclezoro
reviewed
Aug 14, 2023
forcodedancing
force-pushed
the
payment_refactor
branch
from
5509906
to
ab4b18e
Compare
forcodedancing
force-pushed
the
payment_refactor
branch
from
b45aa70
to
590046d
Compare
unclezoro
approved these changes
Aug 14, 2023
|
Please resolve the conflicts |
resolved |
fynnss
approved these changes
Aug 15, 2023
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will update the price logic and billing calculation.
Rationale
Example
QueryGlobalSpStorePriceByTimeChanges
Notable changes: