fix some review comments

bnb-chain · Aug 14, 2023 · 590046d · 590046d
1 parent 33f046a
commit 590046d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/x/sp/keeper/msg_server.go b/x/sp/keeper/msg_server.go
@@ -338,9 +338,9 @@ func (k msgServer) UpdateSpStoragePrice(goCtx context.Context, msg *types.MsgUpd
 }
 
 func IsLastDaysOfTheMonth(now time.Time, days int) bool {
+	now = now.UTC()
 	year, month, _ := now.Date()
-	location := now.Location()
-	nextMonth := time.Date(year, month+1, 1, 0, 0, 0, 0, location)
+	nextMonth := time.Date(year, month+1, 1, 0, 0, 0, 0, time.FixedZone("UTC", 0))
 	daysBack := nextMonth.AddDate(0, 0, -1*days)
 	return now.After(daysBack)
 }

diff --git a/x/sp/keeper/msg_server_test.go b/x/sp/keeper/msg_server_test.go
@@ -153,8 +153,8 @@ func (s *KeeperTestSuite) TestMsgCreateStorageProvider() {
 }
 
 func (s *KeeperTestSuite) TestIsLastDaysOfTheMonth() {
-	s.Require().True(!keeper.IsLastDaysOfTheMonth(time.Unix(1693242061, 0).UTC(), 2)) // 2023-08-28 UTC
-	s.Require().True(!keeper.IsLastDaysOfTheMonth(time.Unix(1693328461, 0).UTC(), 2)) // 2023-08-29 UTC
-	s.Require().True(keeper.IsLastDaysOfTheMonth(time.Unix(1693414861, 0).UTC(), 2))  // 2023-08-30 UTC
-	s.Require().True(!keeper.IsLastDaysOfTheMonth(time.Unix(1693587661, 0).UTC(), 2)) // 2023-09-01 UTC
+	s.Require().True(!keeper.IsLastDaysOfTheMonth(time.Unix(1693242061, 0), 2)) // 2023-08-28 UTC
+	s.Require().True(!keeper.IsLastDaysOfTheMonth(time.Unix(1693328461, 0), 2)) // 2023-08-29 UTC
+	s.Require().True(keeper.IsLastDaysOfTheMonth(time.Unix(1693414861, 0), 2))  // 2023-08-30 UTC
+	s.Require().True(!keeper.IsLastDaysOfTheMonth(time.Unix(1693587661, 0), 2)) // 2023-09-01 UTC
 }