Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: binder: Improve try_from vec #39

Merged
merged 1 commit into from
May 16, 2024
Merged

build: binder: Improve try_from vec #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions build/binder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,25 @@ pub fn generate<W: Write>(modules: Vec<String>, out: &mut W) {
type Error = String; // TODO: define error types for each kind of failure

fn try_from(buffer: &Vec<u8>) -> Result<Self, Self::Error> {
const MIN_MSG_SIZE: usize = 10;

// Parse start1 and start2
if !((buffer[0] == HEADER[0]) && (buffer[1] == HEADER[1])) {
return Err(format!("Message should start with \"BR\" ASCII sequence, received: [{0}({:0x}), {1}({:0x})]", buffer[0], buffer[1]));
}

if buffer.len() < MIN_MSG_SIZE {
return Err(format!("Message is too short, should be at least {MIN_MSG_SIZE} bytes").into());
}

let payload_length = u16::from_le_bytes([buffer[2], buffer[3]]);
if payload_length as usize + MIN_MSG_SIZE != buffer.len() {
return Err(format!(
"Payload length does not match, expected: {payload_length}, received: {}",
buffer.len() - MIN_MSG_SIZE
));
}

let protocol_message = ProtocolMessage {
payload_length,
message_id: u16::from_le_bytes([buffer[4], buffer[5]]),
Expand Down
Loading