build: binder: Improve try_from vec #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build/binder.rs
Outdated
| @@ -109,8 +109,20 @@ pub fn generate<W: Write>(modules: Vec<String>, out: &mut W) { | |||
| if !((buffer[0] == HEADER[0]) && (buffer[1] == HEADER[1])) { | |||
| return Err(format!("Message should start with \"BR\" ASCII sequence, received: [{0}({:0x}), {1}({:0x})]", buffer[0], buffer[1])); | |||
| } | |||
| if buffer.len() < 10 { | |||
There was a problem hiding this comment.
maybe we can give this 10 offset a name defining it as a local const?
RaulTrombin
reviewed
May 16, 2024
build/binder.rs
Outdated
| @@ -109,8 +109,20 @@ pub fn generate<W: Write>(modules: Vec<String>, out: &mut W) { | |||
| if !((buffer[0] == HEADER[0]) && (buffer[1] == HEADER[1])) { | |||
| return Err(format!("Message should start with \"BR\" ASCII sequence, received: [{0}({:0x}), {1}({:0x})]", buffer[0], buffer[1])); | |||
| } | |||
| if buffer.len() < 10 { | |||
There was a problem hiding this comment.
Suggested change
| if buffer.len() < 10 { | |
| const MIN_MSG_SIZE : usize = 10; | |
| if buffer.len() < MIN_MSG_SIZE { |
build/binder.rs
Outdated
Comment on lines
118
to
126
| if payload_length as usize + 10 != buffer.len() { | ||
| return Err(format!( | ||
| "Payload length does not match, expected: {}, received: {}", | ||
| payload_length, | ||
| buffer.len() - 10 | ||
| )); | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if payload_length as usize + 10 != buffer.len() { | |
| return Err(format!( | |
| "Payload length does not match, expected: {}, received: {}", | |
| payload_length, | |
| buffer.len() - 10 | |
| )); | |
| } | |
| if payload_length as usize + MIN_MSG_SIZE != buffer.len() { | |
| let received_payload_lenght = buffer.len() - 10; | |
| return Err(format!( | |
| "Payload length does not match, expected: {payload_length}, received: {received_payload_lenght}" | |
| )); | |
| } | |
There was a problem hiding this comment.
Moved to use MIN_MSG_SIZE, I see not point of creating an intermediary variable for a print.
patrickelectric
force-pushed
the
add-more-tests
branch
4 times, most recently
from
0a81fd6
to
2f736f9
Compare
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
add-more-tests
branch
from
2f736f9
to
649fa85
Compare
RaulTrombin
approved these changes
May 16, 2024
joaoantoniocardoso
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.