Allow blocking IPs from transmitting WebRTC video #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents candidates that come from unwanted sources, like WiFi connections.
joaoantoniocardoso
approved these changes
Nov 17, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to ES-Alexander/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added a commit
to bluerobotics/ardusub-zola
that referenced
this pull request
Nov 24, 2023
ES-Alexander
added
docs-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the user to select which IPs should be allowed to transmit WebRTC video streams.
The selection is persistent between boots.
The only thing missing now is a popup saying to the user that he should define those (when they are undefined).
The solution was developed by @joaoantoniocardoso at #564. I kept his commits and polished the solution from there.
Fix #526
Screen.Recording.2023-11-17.at.17.13.29.mp4