Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement a simple exclusive filter by IP address #564

Closed

Conversation

joaoantoniocardoso
Copy link
Member

Helps #526

The UI part is so bad, but this simple filter works.

@joaoantoniocardoso
Copy link
Member Author

@rafaellehmkuhl I have zero knowledge of why Bun is failing, plus, I'm using so much time fighting with the frontend that I feel it would take me hours to make it right, could you assume this from here?

@@ -244,7 +244,7 @@ watch(externalStreams, () => {
// Retrieve stream from the saved stream name, otherwise choose the first available stream as a fallback
const savedStream = savedStreamName ? availableStreams.value.find((s) => s.name === savedStreamName) : undefined

if (savedStream !== undefined && savedStream !== selectedStream.value && selectedStream.value === undefined) {
if (savedStream !== undefined && savedStream.id !== selectedStream.value?.id && selectedStream.value === undefined) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to the patch, just noticed that was wrong.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

@@ -133,7 +182,7 @@ watch(availableStreams, () => {
? availableStreams.value.find((s) => s.name === savedStreamName)
: availableStreams.value.first()

if (savedStream !== undefined && savedStream !== selectedStream.value) {
if (savedStream !== undefined && savedStream.id !== selectedStream.value?.id) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to the patch, just noticed that was wrong.

@rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl I have zero knowledge of why Bun is failing, plus, I'm using so much time fighting with the frontend that I feel it would take me hours to make it right, could you assume this from here?

I can, yes.

@joaoantoniocardoso
Copy link
Member Author

@rafaellehmkuhl I have zero knowledge of why Bun is failing, plus, I'm using so much time fighting with the frontend that I feel it would take me hours to make it right, could you assume this from here?

I can, yes.

Great, call me if any help is needed!

@rafaellehmkuhl
Copy link
Member

Closing in favor of #571 as requested by @joaoantoniocardoso.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants