-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support status text messages #370
Merged
patrickelectric
merged 11 commits into
bluerobotics:master
from
rafaellehmkuhl:support-status-text-messages
Jul 6, 2023
Merged
Support status text messages #370
patrickelectric
merged 11 commits into
bluerobotics:master
from
rafaellehmkuhl:support-status-text-messages
Jul 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rafaellehmkuhl
commented
Jun 29, 2023
•
edited
Loading
edited
- Support StatusText messages coming from the autopilot
- Create alerts based on the status
- Add audio support for the status
- Add audio configuration support (disabling, filtering levels, etc)
- Allow choosing alert voice
- Add level information to alert UI
rafaellehmkuhl
force-pushed
the
support-status-text-messages
branch
from
June 30, 2023 18:29
e3dffdd
to
1a9a0d7
Compare
This helps with long messages, that are being truncated right now.
This is a message with a severity level, used for direct alerts from the vehicle to the user/gcs. Co-authored-by: Willian Galvani <[email protected]>
Co-authored-by: Willian Galvani <[email protected]>
So watchers are correctly notified when the array is changed.
Co-authored-by: Willian Galvani <[email protected]>
There are some voices that are very buggy on some systems. Letting the user choose the voice allows fixing this.
rafaellehmkuhl
force-pushed
the
support-status-text-messages
branch
from
July 5, 2023 17:26
1a9a0d7
to
b1557e8
Compare
rafaellehmkuhl
force-pushed
the
support-status-text-messages
branch
from
July 5, 2023 19:32
b1557e8
to
2e89b92
Compare
patrickelectric
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.