Arcdps Integration Rewrite #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Denrage
force-pushed
the
feat/arcdps_bridge_rewrite
branch
from
84533cd
to
57e8088
Compare
dlamkins
approved these changes
Mar 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion Reference
https://discord.com/channels/531175899588984842/536970543736291346/1179936940477394945
Is this a breaking change?
No
This PR updates the ArcDPS-Service of Blish-Hud. It is in preparations for the rewrite of the arcdps bridge update.
The socket is completely rewritten from scratch with performance and readability in mind. It is also way simpler which should make the code less prone to errors.
There is a new V2 Service as discussed that has a simpler API to interact with the bridge. All calls to third parties are also run in parallel and away from the socket thread, so it wont block if someone has a long running handlet.
The V1 Service now wraps the V2 service and should behave exactly the same as before (tested with CustomCombatText).
The V2 Service checks for the open port of the V2 arcdps bridge dll and if it cant make a connection to it, it will create a V1 client that is still fully supported.
The goal was that everything existing that is using the ArcDPS-Service doesn't realize that everything changed under the hood and everyone with an old arcdps bridge dll won't notice any problems either that didn't exist bf the rewrite