Fixed SonarCloud issues

blish-hud · Mar 11, 2024 · 84533cd · 84533cd
1 parent d50550f
commit 84533cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Blish HUD/GameServices/ArcDps/V2/ArcDpsClient.cs b/Blish HUD/GameServices/ArcDps/V2/ArcDpsClient.cs
@@ -69,7 +69,7 @@ public void RegisterMessageTypeListener<T>(int type, Func<T, CancellationToken,
         }
 
         private void ProcessMessage(MessageProcessor processor, BlockingCollection<byte[]> messageQueue) {
-            while (true) {
+            while (!ct.IsCancellationRequested) {
                 ct.ThrowIfCancellationRequested();
                 Task.Delay(1).Wait();
                 foreach (var item in messageQueue.GetConsumingEnumerable()) {
@@ -78,6 +78,8 @@ private void ProcessMessage(MessageProcessor processor, BlockingCollection<byte[
                     ArrayPool<byte>.Shared.Return(item);
                 }
             }
+
+            ct.ThrowIfCancellationRequested();
         }
 
         /// <summary>

diff --git a/Blish HUD/GameServices/ArcDpsServiceV2.cs b/Blish HUD/GameServices/ArcDpsServiceV2.cs
@@ -136,7 +136,7 @@ private static int GetPort(uint processId, ArcDpsBridgeVersion version) {
         protected override void Unload() {
             Gw2Mumble.Info.ProcessIdChanged -= Start;
             _arcDpsClientCancellationTokenSource.Cancel();
-
+            _arcDpsClientCancellationTokenSource.Dispose();
             _stopwatch.Stop();
             _arcDpsClient.Disconnect();
             _arcDpsClient.Error -= SocketErrorHandler;