Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ADIv5 DP init #1544

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Fix: ADIv5 DP init #1544

merged 2 commits into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. target/adiv5: remove unused try except block 

    This try execpt block was watching for a timeout, but there are at the
moment no timeout exceptions thrown in the codebase

The original exeption present in the adiv5_dp_read stack this code was
likely handling was removed in commit:
0c63903
where the abort to recover from bad access implemented by the
exeption case of this block was also implemented at a lower level
this means the exception block code was never run, and the re-read on
timeout probably stoped happening since then

Currently a protocol recovery mechanism is implemented which should
provide the functionality this code was originally trying to employ
    @perigoso
    perigoso committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    207f4d3 View commit details
    Browse the repository at this point in the history

  2. target/adiv5: refactor adiv5_dp_init dpidr handling 

    This sees the introduction of adiv5_read_dpidr, which keeps the
try except funkiness contained and prevents the need for volatile
variables in the scope of more complex functions blocking
possible optimizations
    @perigoso
    perigoso committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    f039068 View commit details
    Browse the repository at this point in the history