Fix: ADIv5 DP init #1544
Merged
Fix: ADIv5 DP init #1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This try execpt block was watching for a timeout, but there are at the moment no timeout exceptions thrown in the codebase The original exeption present in the adiv5_dp_read stack this code was likely handling was removed in commit: 0c63903 where the abort to recover from bad access implemented by the exeption case of this block was also implemented at a lower level this means the exception block code was never run, and the re-read on timeout probably stoped happening since then Currently a protocol recovery mechanism is implemented which should provide the functionality this code was originally trying to employ
dragonmux
requested changes
Jul 19, 2023
This sees the introduction of adiv5_read_dpidr, which keeps the try except funkiness contained and prevents the need for volatile variables in the scope of more complex functions blocking possible optimizations
perigoso
force-pushed
the
fix/adiv5_dp_init
branch
from
83e64dc
to
f039068
Compare
ALTracer
reviewed
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR does a much needed cleanup in
adiv5_dp_init, related to theTRY_CATCHblocksTRY_CATCHbrings clobbering errors, forcing us to volatile certain variables and thus blocking certain optimizationsThis contains the problematic code and unblocks optimizations, bringing a small code size saving
Tested with BMDA (J-Link V8) and native on a RP2040 target
Your checklist for this pull request
make PROBE_HOST=native)make PROBE_HOST=hosted)Closing issues