[bitnami/zookeeper] Drop unused getValueFromSecret local helper
#29440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promote the use of common helpers `common.secrets.passwords.manage` Signed-off-by: Léo Colombaro <[email protected]>
3 tasks
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Andrés Bono <[email protected]>
Signed-off-by: Andrés Bono <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
andresbono
approved these changes
Sep 23, 2024
This was referenced Oct 13, 2024
mike12806
pushed a commit
to mike12806/charts
that referenced
this pull request
Oct 30, 2024
…tnami#29440) * [bitnami/zookeeper] Drop unused `getValueFromSecret` local helper Promote the use of common helpers `common.secrets.passwords.manage` Signed-off-by: Léo Colombaro <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> * Bump chart version again Signed-off-by: Andrés Bono <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <[email protected]> --------- Signed-off-by: Léo Colombaro <[email protected]> Signed-off-by: Bitnami Containers <[email protected]> Signed-off-by: Andrés Bono <[email protected]> Co-authored-by: Bitnami Containers <[email protected]> Co-authored-by: Andrés Bono <[email protected]> Signed-off-by: Michael Faherty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Remove the unused, undocumented, un-namespaced
getValueFromSecretlocal helper for the following charts:getValueFromSecretlocal helper #29880getValueFromSecretlocal helper #29440Benefits
Promote the use of common helpers
common.secrets.passwords.manage, properly defined.Should also help to reduce errors/mismatches around secret lookups.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.