[bitnami/mysql] Drop unused getValueFromSecret local helper
#29431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you so much for the PR! Could you divide it into two separate PRs? We need it for our automations to properly work |
3 tasks
LeoColomb
changed the title
getValueFromSecret local helpergetValueFromSecret local helper
Promote the use of common helpers `common.secrets.passwords.manage` Signed-off-by: Léo Colombaro <[email protected]>
LeoColomb
force-pushed
the
fix/mysql-helper-common
branch
from
1b78b83
to
9662c1f
Compare
|
@javsalgar No problem, split with #29440 |
Signed-off-by: Bitnami Containers <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Containers <[email protected]>
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
|
Hoping this can still be reviewed 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Remove the unused, undocumented, un-namespaced
getValueFromSecretlocal helper for the following charts:getValueFromSecretlocal helper #29431getValueFromSecretlocal helper #29440Benefits
Promote the use of common helpers
common.secrets.passwords.manage, properly defined.Should also help to reduce errors/mismatches around secret lookups.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.