Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action testing #24

Merged
merged 16 commits into from
Feb 23, 2024
Merged

Conversation

ColmTalbot
Copy link
Collaborator

@ColmTalbot ColmTalbot commented Feb 22, 2024

This PR adds some of our CI jobs via GitHub actions.

  • Run the pre-commit tests
  • Run our unit tests and sampler run tests in a single job to reduce the number of pulls that need to be done for the docker image
  • Run our basic install from scratch tests for a range of python versions
  • Build the documentation - I think we don't want to actually deploy the docs as we don't want to have multiple versions of the docs floating around.

This PR doesn't cover things that are currently on our scheduled tests, e.g., building containers, plotting tests, and example tests

@GregoryAshton
Copy link
Collaborator

@ColmTalbot there are a bunch of material changes (i.e. the updated author list). Is this just because the target branch is out of date?

@ColmTalbot
Copy link
Collaborator Author

@ColmTalbot there are a bunch of material changes (i.e. the updated author list). Is this just because the target branch is out of date?

I just rebased github-main from master. This process needs to be documented.

@ColmTalbot ColmTalbot marked this pull request as ready for review February 23, 2024 15:16
@ColmTalbot
Copy link
Collaborator Author

I think all the tests we need are now run here. The layout is flat and could probably be put into a more sensible flow, but I think this is enough for now.

Copy link
Collaborator

@GregoryAshton GregoryAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the additions.

@ColmTalbot ColmTalbot merged commit 8137c12 into github-main Feb 23, 2024
12 checks passed
@ColmTalbot ColmTalbot deleted the add-github-action-testing branch February 23, 2024 15:29
@ColmTalbot
Copy link
Collaborator Author

For future reference, the squash and merge option is the merge option we want.

ColmTalbot added a commit that referenced this pull request Feb 24, 2024
* TST: Create unit-tests.yml

* TST: try explicit version

* TST: Remove unnecessary setup python

* TST: disable precommit tests

* TST: typo

* TST: add pre-commit tests

* TST: try installing jupyter for pre-commit

* TST: add install/import tests

* TST: just install basic version

* TST: typo fixes

* TST: done run executable tests on windows

* TST: another attempt to disable executable tests for windows

* TST: remove executable tests

* DOC: add documentation job

* DOC: make sure to pull tags for docs job

* BLD: upload docs as an artifact
ColmTalbot added a commit that referenced this pull request Sep 17, 2024
* TST: Create unit-tests.yml

* TST: try explicit version

* TST: Remove unnecessary setup python

* TST: disable precommit tests

* TST: typo

* TST: add pre-commit tests

* TST: try installing jupyter for pre-commit

* TST: add install/import tests

* TST: just install basic version

* TST: typo fixes

* TST: done run executable tests on windows

* TST: another attempt to disable executable tests for windows

* TST: remove executable tests

* DOC: add documentation job

* DOC: make sure to pull tags for docs job

* BLD: upload docs as an artifact
@ColmTalbot ColmTalbot mentioned this pull request Oct 3, 2024
47 tasks
ColmTalbot added a commit that referenced this pull request Oct 23, 2024
* BUG: fix typo in ln_i0

* TST: Add GitHub action testing (#24)

* TST: Create unit-tests.yml

* TST: try explicit version

* TST: Remove unnecessary setup python

* TST: disable precommit tests

* TST: typo

* TST: add pre-commit tests

* TST: try installing jupyter for pre-commit

* TST: add install/import tests

* TST: just install basic version

* TST: typo fixes

* TST: done run executable tests on windows

* TST: another attempt to disable executable tests for windows

* TST: remove executable tests

* DOC: add documentation job

* DOC: make sure to pull tags for docs job

* BLD: upload docs as an artifact

* DEP: Update documentation and examples to reflect changes to random seed

* DEP,DOC: Updated doc string to ask for np generator instance instead of legacy generator

* [DEP][DOC]: updates from review, typo fix, removal of unnecessary `rng` import

* [?]: Removed metadata from jupyter notebooks

* Pre-commit fixes

* pre-commit re-run

I realised that pre-commit didn't check any files because there were no logged chagnes. So I ran pre-commit on everything using "pre-commit run --all-files".

This only brought up relevant changes from myself, with the exceptions of:
"bilby/bilby_mcmc/sampler.py:525:38: E226 missing whitespace around arithmetic operator"
which is outside the remit of this merge request.

* Adding Sean to the authors for the CI

* Update bilby/core/sampler/dynesty_utils.py

Co-authored-by: Colm Talbot <[email protected]>

* Update bilby/core/sampler/dynesty_utils.py

Co-authored-by: Colm Talbot <[email protected]>

---------

Co-authored-by: Colm Talbot <[email protected]>
Co-authored-by: Colm Talbot <[email protected]>
Co-authored-by: Sean Hibbit <[email protected]>
Co-authored-by: Sean Hibbitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants