-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub action testing #24
Conversation
69cddb7
to
1bd59ff
Compare
@ColmTalbot there are a bunch of material changes (i.e. the updated author list). Is this just because the target branch is out of date? |
d0b6806
to
7ba2fe1
Compare
I just rebased |
I think all the tests we need are now run here. The layout is flat and could probably be put into a more sensible flow, but I think this is enough for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the additions.
For future reference, the squash and merge option is the merge option we want. |
* TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact
* TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact
* BUG: fix typo in ln_i0 * TST: Add GitHub action testing (#24) * TST: Create unit-tests.yml * TST: try explicit version * TST: Remove unnecessary setup python * TST: disable precommit tests * TST: typo * TST: add pre-commit tests * TST: try installing jupyter for pre-commit * TST: add install/import tests * TST: just install basic version * TST: typo fixes * TST: done run executable tests on windows * TST: another attempt to disable executable tests for windows * TST: remove executable tests * DOC: add documentation job * DOC: make sure to pull tags for docs job * BLD: upload docs as an artifact * DEP: Update documentation and examples to reflect changes to random seed * DEP,DOC: Updated doc string to ask for np generator instance instead of legacy generator * [DEP][DOC]: updates from review, typo fix, removal of unnecessary `rng` import * [?]: Removed metadata from jupyter notebooks * Pre-commit fixes * pre-commit re-run I realised that pre-commit didn't check any files because there were no logged chagnes. So I ran pre-commit on everything using "pre-commit run --all-files". This only brought up relevant changes from myself, with the exceptions of: "bilby/bilby_mcmc/sampler.py:525:38: E226 missing whitespace around arithmetic operator" which is outside the remit of this merge request. * Adding Sean to the authors for the CI * Update bilby/core/sampler/dynesty_utils.py Co-authored-by: Colm Talbot <[email protected]> * Update bilby/core/sampler/dynesty_utils.py Co-authored-by: Colm Talbot <[email protected]> --------- Co-authored-by: Colm Talbot <[email protected]> Co-authored-by: Colm Talbot <[email protected]> Co-authored-by: Sean Hibbit <[email protected]> Co-authored-by: Sean Hibbitt <[email protected]>
This PR adds some of our CI jobs via GitHub actions.
This PR doesn't cover things that are currently on our scheduled tests, e.g., building containers, plotting tests, and example tests