Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update Python versions we test against. #215

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

sellth
Copy link
Contributor

@sellth sellth commented Jan 23, 2024

No description provided.

@sellth sellth linked an issue Jan 23, 2024 that may be closed by this pull request
@Nicolai-vKuegelgen
Copy link
Contributor

Closed via #216

@sellth
Copy link
Contributor Author

sellth commented Jan 24, 2024

Not solved by #216 . Dependency conflicts caused by pysam bioconda package and snappy-pipeline block Python 3.11/3.12

@sellth sellth reopened this Jan 24, 2024
@sellth sellth self-assigned this Jan 24, 2024
@sellth
Copy link
Contributor Author

sellth commented Jan 24, 2024

test_run_seasnap_itransfer_results_smoke_test fails because fake_filesystem vodoo stops working.

Copy link
Contributor

Please format your code with black: make black.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (b7fd7f1) to head (4a43396).
Report is 13 commits behind head on main.

Current head 4a43396 differs from pull request most recent head 2bc0aaf

Please upload reports for the commit 2bc0aaf to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   80.51%   80.49%   -0.02%     
==========================================
  Files         102      102              
  Lines        7966     7964       -2     
==========================================
- Hits         6414     6411       -3     
- Misses       1552     1553       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Nicolai-vKuegelgen Nicolai-vKuegelgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

not sure if we want to roll back the pysam thing in the future, maybe make an issue?

Comment on lines 80 to 83
# We are missing bioconda pysam packages for 3.11 and 3.12, cf.
# https://github.com/bioconda/bioconda-recipes/issues/37805
# - name: Save time by installing packages via mamba.
# run: mamba install -y pysam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should open an issue, so this doesn't get lost?

@sellth
Copy link
Contributor Author

sellth commented Jan 29, 2024

Currently blocked by:

@sellth
Copy link
Contributor Author

sellth commented Jun 25, 2024

We need a new biomedsheets PyPI release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newest varfish-cli is not compatible with python 3.8
2 participants