Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newest varfish-cli is not compatible with python 3.8 #214

Closed
Nicolai-vKuegelgen opened this issue Jan 23, 2024 · 2 comments · May be fixed by #215
Closed

Newest varfish-cli is not compatible with python 3.8 #214

Nicolai-vKuegelgen opened this issue Jan 23, 2024 · 2 comments · May be fixed by #215
Assignees
@sellth

Comments

@Nicolai-vKuegelgen
Copy link
Contributor

Describe the bug
cubi-tk CI currently tests against python 3.8, 3.9 & 3.10.
cubi-tk also imports the varfish-cli (which tests 3.10-3.12). The varfish-cli started using typing.Annotated in version 0.6.*, which is not available in python 3.8 and thus breaks the cubi-tk tests run under that version.

To Reproduce
Steps to reproduce the behavior:

  • try/check any recent CI run that installs varfish-cli >= 0.6.*

Expected behavior
Since we likely want to keep using the newest varfish-cli version, it seems that we need to drop python 3.8 support.
@sellth
Copy link
Contributor

sellth commented Jan 23, 2024

Easiest fix: Update our python versions to 3.10+

@sellth sellth self-assigned this Jan 23, 2024
@sellth sellth linked a pull request Jan 23, 2024 that will close this issue
ci: Update Python versions we test against. #215
Open
@Nicolai-vKuegelgen
Copy link
Contributor Author

Circumvented as of #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sellth sellth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Update Python versions we test against. bihealth/cubi-tk
2 participants
@Nicolai-vKuegelgen @sellth