fix htmx.ajax defaulting to swap body when target not found #2878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The htmx.ajax helper function can cause issues when the target is not set correctly or the target selector happens to be missing in the DOM as it passes in null target override to the ajax request which defaults to targeting the body. Changing it to detect invalid targets and pass in a DUMMY_ELT which triggers the htmx:targetError solves this. Also had to handle situations where a valid source is supplied as its valid to fall back to source targeting an explicit target is not defined but if we still want it to fail if target was defined.
Corresponding issue:
#2869
Testing
Wrote some new tests to cover most invalid targeting situations and also tested calling htmx.ajax manually to confirm it rejects invalid targets but passes though valid ones fine.
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded