ajax helper with no source or target defaults to body #2948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
recent change #2878 has caused the default behavior of the ajax helper function for when no source or target is supplied to change to error on a target error instead of targeting body as it should do by default. The recent fix was put in to handle situations where an invalid source or target were supplied which would previously fall back to targeting body in error but the logic for that fix did not handle the case where nothing is supplied for source or target.
Corresponding issue:
#2945
Testing
Added test for when both source and target not set to make sure it targets body as expected
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded