Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ajax helper with no source or target defaults to body #2948

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

MichaelWest22
Copy link
Contributor

@MichaelWest22 MichaelWest22 commented Oct 7, 2024

Description

recent change #2878 has caused the default behavior of the ajax helper function for when no source or target is supplied to change to error on a target error instead of targeting body as it should do by default. The recent fix was put in to handle situations where an invalid source or target were supplied which would previously fall back to targeting body in error but the logic for that fix did not handle the case where nothing is supplied for source or target.

Corresponding issue:
#2945

Testing

Added test for when both source and target not set to make sure it targets body as expected

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@Telroshan Telroshan added the bug Something isn't working label Oct 7, 2024
@Telroshan Telroshan added the ready for review Issues that are ready to be considered for merging label Oct 7, 2024
@1cg 1cg merged commit 816fe6d into bigskysoftware:dev Oct 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review Issues that are ready to be considered for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants