Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate scrape method #82

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

newsroomdev
Copy link
Member

Description

Following the CODEOWNERS the decision to deprecate scrape, this PR removes the unused method. A separate application layer handles scraping to manage the downloads for researchers. Please refer to the discussion thread regarding the metadata format the CLEAN project uses to archive and analyze police misconduct assets.

Summary of Changes

  • Removes def scrape methods in the existing codebase
  • Deletes unused imports
  • Updates docstrings

Related Issues

@newsroomdev
Copy link
Member Author

Tagging @stucka and @naumansharifwork for awareness regarding currently open pull requests. The scrape method was a helpful first step to a more robust pipeline in a separate application layer. Feel free to reach out in the GitHub discussion thread about metadata if there are concerns

@newsroomdev newsroomdev linked an issue Aug 14, 2024 that may be closed by this pull request
2 tasks
@newsroomdev newsroomdev marked this pull request as ready for review August 19, 2024 18:37
@newsroomdev
Copy link
Member Author

tagging @zstumgoren for awareness 🥳
Screenshot 2024-08-19 at 11 42 49 AM

@newsroomdev newsroomdev merged commit 9de55ae into dev Aug 19, 2024
3 checks passed
@newsroomdev newsroomdev deleted the refactor/remove-scrape branch August 19, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: remove scrape method + cli cmd
1 participant