added scrape-meta and scrape for riverside pd #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zstumgoren @newsroomdev please review this PR as well i have formatted the json as it was mentioned in the discussion |
tarakc02
requested changes
Aug 5, 2024
There was a problem hiding this comment.
@naumansharifwork, sorry i misesed this earlier, but filename/slug should be "riverside_pd" rather than "river_side_pd". otherwise i don't have any other changes, it looks good to me.
tarakc02
requested changes
Aug 9, 2024
clean/ca/riverside_pd.py
Outdated
|
Hey @zstumgoren please review this as well, Thanks |
newsroomdev
requested changes
Aug 13, 2024
|
This is looking very close to being done! Nice work. Two changes and this should be good to merge. Let me know when you'd like me to take another look, and thank you for your diligence as this codebase adds downstream dependencies |
|
Hey @newsroomdev Thanks for the review, the requested changes are done please check Thanks. |
newsroomdev
approved these changes
Aug 15, 2024
naumansharifwork
added a commit
to naumansharifwork/clean-scraper
that referenced
this pull request
Oct 23, 2024
* added scrape-meta and scrape for riverside pd * changes for meta-data file formating * changed file name * tiny fix * removed scrape and changed case_num to case_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey fellows,
Created scraper for City of Riverside,
Below is the tree screenshot and meta json
i have made folder name as case numbers.
ca_river_side_pd.json