Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ephys.md #1681

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Update ephys.md #1681

merged 1 commit into from
Jan 12, 2024

Conversation

arnodelorme
Copy link

--- PLEASE READ AND DELETE THE TEXT BELOW BEFORE OPENING THE PULL REQUEST ---

See the CONTRIBUTING guide. Specifically:

  • Please keep the title of your Pull Request (PR) short but informative - it will
    appear in the changelog.
  • If you do not want a PR to appear in the changelog, it must receive the exclude-from-changelog label.
  • Please ensure your name is credited on our Contributors appendix.
    To add your name, please edit our Contributors wiki and add your name with the type of contribution.
    For assistance, please tag @bids-standard/maintainers.
  • Use one of the following prefixes in the title of your PR:
    • [ENH] - enhancement of the specification that adds a new feature or
      support for a new data type
    • [FIX] - fix of a typo or language clarification
    • [INFRA] - changes to the infrastructure automating the specification
      release (for example building HTML docs)
    • [SCHEMA] - changes to the BIDS schema and/or related code
    • [MISC] - everything else including changes to the file listing
      contributors
  • If you are opening a PR to obtain early feedback, but the changes
    are not ready to be merged (also known as a "Work in Progress" PR), please
    use a Draft PR.
  • After opening the PR, our continuous integration services will automatically check your contribution for formatting errors and render a preview of the BIDS specification with your changes.
    To see the checks and preview, scroll down and click on the show all checks link.
    From the list, select the Details link of the ci/circleci: build_docs artifact check to see the preview of the BIDS specification.
  • If you are updating the schema and you need to subsequently make changes to the bidsschematools code (validation, tests, rendering), this means your PR probably introduces a compatibility breaking change and you should increment the minor version (the second number) in bids-specification/src/schema/SCHEMA_VERSION.

--- PLEASE READ AND DELETE THE TEXT ABOVE BEFORE OPENING THE PULL REQUEST ---

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a550cc5) 87.97% compared to head (9c76180) 87.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           bep021    #1681   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files          16       16           
  Lines        1356     1356           
=======================================
  Hits         1193     1193           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies merged commit 7ed9007 into bids-standard:bep021 Jan 12, 2024
21 checks passed
effigies pushed a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants