-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1 main code #18
1 main code #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and runs on my machine. Nice work! I added some small remarks, other than that ready to merge, I'd say :)
Oh and of course it would be really great to add some automated tests, for instance for the config settings. |
I tried to run it on GPU via Docker, but it's more complicated than I thought. It expects CUDA version 11.x, but I tried several things and none of them work. I might have to do a multi-stage build in order to make it work. I could test if the GPU works the S3 way since, in that case, it will run locally, without needing Docker (if I remember correctly). Otherwise, if you have ideas on how to address this, let me know I will also be adding tests, but for another issue |
Closes #1
Added the main code that runs Whisper on audio to generate transcriptions.
When testing, I recommend using the CPU for processing (it is already set to that in the config.yml). If you happen to have a more powerful Nvidia GPU available, then you can change the value to
cuda
and test it (I will also test it myself using a GPU I have available).I have also already tested the
vad
andword_timestamps
settings and it seems to be working fine.