Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to shaded jar file #43

Conversation

dkovalenkoI
Copy link
Contributor

@dkovalenkoI dkovalenkoI commented Jul 24, 2023

Summary:
Add license used in the JDBC driver to the shaded jar

Description:

  • The license file needs to be under jdbc/src/main/resources/META-INF so it could be included in the shaded jar automatically when jar is built.
  • Copy THIRD-PARTY-LICENSES.txt to jdbc/src/main/resources/META-INF in pom.xml when mvn build starts
  • Add jdbc/src/main/resources/META-INF/THIRD-PARTY-LICENSES.txt to .gitignore to avoid it to be added to git repo as it is only for build purpose.

Test:

  • Run jar -xf amazon-timestream-jdbc-2.0.0-shaded.jar to extract. TheTHIRD-PARTY-LICENSES.txt could be found under directory META-INF.
  • Test the shaded jar using DbVisualizer, the JDBC connection creation and queries could run successfully.

Issue:
issues-37

@sethusrinivasan sethusrinivasan merged commit 2f21431 into awslabs:main Aug 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants