Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaded jar should include THIRD-PARTY-LICENSES.txt? #37

Closed
hyandell opened this issue Apr 20, 2023 · 1 comment
Closed

Shaded jar should include THIRD-PARTY-LICENSES.txt? #37

hyandell opened this issue Apr 20, 2023 · 1 comment

Comments

@hyandell
Copy link

Looking at the latest released shaded jar, it strikes me that it should have the dependency licenses more explicitly called out than just the pom.xml files (and random NOTICE files that get included by Maven shading).

Is including THIRD-PARTY-LICENSES.txt the way to go?

@dkovalenkoI
Copy link
Contributor

dkovalenkoI commented Jul 26, 2023

@hyandell , The pull request has been created to address the reported issue. The fix will be delivered with the next version of our product.

Thank you for your patience and valuable feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants