Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Ruff accross the project #489

Merged
merged 33 commits into from
Sep 20, 2023

Conversation

BastLeblanc
Copy link
Contributor

@BastLeblanc BastLeblanc commented Sep 15, 2023

Issue #, if available: #462

Description of changes:

  • added pyproject.toml to the root of the project
  • ran Ruff and auto fixed errors
  • manual fixes of errors when wrongly fixed by Ruff (generators personalize)
  • new github action on push and pull request to scan for Ruff
  • contribution guidelines : automated checks should be green for a PR to be accepted

Description of testing performed to validate your changes (required if pull request includes CloudFormation or source code changes):

  • local unit tests
  • deployment of the CFN, with and without the auto create resources

Notes

  • for now I ignored Line too long E501 - gives too many warnings, and requires a bit more work to test all the code base. But I propose that this would be asked for any new dev

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adibuer-lab and others added 30 commits August 29, 2023 16:26
…rints rather than relying on import side effects
@BastLeblanc BastLeblanc self-assigned this Sep 15, 2023
@dairiley dairiley self-requested a review September 20, 2023 16:32
Copy link
Collaborator

@dairiley dairiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BastLeblanc BastLeblanc merged commit 4d601a3 into aws-samples:master Sep 20, 2023
1 check passed
@BastLeblanc BastLeblanc deleted the ruff branch September 20, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped
Development

Successfully merging this pull request may close these issues.

3 participants