Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable resource requests and limits through command arguments. #65

Merged
merged 27 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
ff467f4
Added a configurable instrumentation config argument to be passed int…
musa-asad Jul 17, 2024
0c17027
Changed default values.
musa-asad Jul 18, 2024
6df5c9c
Merge branch 'main' into init-resource
musa-asad Jul 18, 2024
2a6e383
Merge branch 'main' into init-resource
musa-asad Jul 23, 2024
bc249da
Reverting to see if errors persist.
musa-asad Jul 23, 2024
f3dcc7b
Revert "Reverting to see if errors persist."
musa-asad Jul 23, 2024
69a39b8
Added language configuration.
musa-asad Jul 23, 2024
868ab20
Adjusted format.
musa-asad Jul 23, 2024
1bac892
Added requests.
musa-asad Jul 24, 2024
1a30429
Fixed order of quantities.
musa-asad Jul 25, 2024
a6489ac
Changed order.
musa-asad Jul 25, 2024
5bcdf30
Better order.
musa-asad Jul 25, 2024
c3601aa
Testing operator.
musa-asad Jul 26, 2024
de564f1
Revert testing changes.
musa-asad Jul 26, 2024
ab6c40f
Fix spacing.
musa-asad Jul 26, 2024
ee930c0
Fix spacing.
musa-asad Jul 26, 2024
c3b60e1
Fix spacing.
musa-asad Jul 26, 2024
41d47cd
Fix spacing.
musa-asad Jul 26, 2024
df7eed9
Revert "Fix spacing."
musa-asad Jul 26, 2024
5f07949
Revert "Fix spacing."
musa-asad Jul 26, 2024
c1afa63
Revert "Revert testing changes."
musa-asad Jul 26, 2024
b9b7ebf
Revert "Testing operator."
musa-asad Jul 26, 2024
0a501d9
Merge branch 'main' into init-resource
musa-asad Aug 9, 2024
a4e2805
Added dotnet configuration
musa-asad Aug 9, 2024
2b217d6
Revert "Added dotnet configuration"
musa-asad Aug 9, 2024
8212d54
Added dotnet configuration.
musa-asad Aug 9, 2024
ab0fc39
Update operator tag.
musa-asad Aug 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ spec:
containers:
- image: {{ template "cloudwatch-agent-operator.image" . }}
args:
- {{ printf "--auto-instrumentation-config=%s" (.Values.initContainers.resources.limits | toJson) | quote }}
- {{ printf "--auto-annotation-config=%s" (.Values.manager.autoAnnotateAutoInstrumentation | toJson) | quote }}
- "--auto-instrumentation-java-image={{ template "auto-instrumentation-java.image" . }}"
- "--auto-instrumentation-python-image={{ template "auto-instrumentation-python.image" . }}"
Expand Down
7 changes: 7 additions & 0 deletions charts/amazon-cloudwatch-observability/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,13 @@ manager:
service:
name:

## Default resource limits for init containers.
initContainers:
resources:
limits:
cpu: 100m
memory: 64Mi
musa-asad marked this conversation as resolved.
Show resolved Hide resolved

## Admission webhooks make sure only requests with correctly formatted rules will get into the Operator.
admissionWebhooks:
create: true
Expand Down
Loading