Allow configurable resource requests and limits through command arguments. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musa-asad
commented
Jul 17, 2024
This reverts commit bc249da.
musa-asad
changed the title
This reverts commit c3601aa.
lisguo
approved these changes
Aug 9, 2024
sky333999
reviewed
Aug 9, 2024
Paramadon
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Allow configurable resource requests and limits through command arguments so operator can take these values and use them for init containers.
Testing:
See aws/amazon-cloudwatch-agent-operator#196.
helm upgrade --install amazon-cloudwatch-observability helm-charts/charts/amazon-cloudwatch-observability --values helm-charts/charts/amazon-cloudwatch-observability/values.yaml --set clusterName=<cluster-name> --set region=us-west-2.kubectl get pods.kubectl describe pod amazon-cloudwatch-observability-controller-manager-####.As we can see, it has the new operator image and command argument.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.